block-sha1: put expanded macro parameters in parentheses
't' is currently always a numeric constant, but it can't hurt to prepare for the day that it becomes useful for a caller to pass in a more complex expression. Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jonathan Nieder committed
Jul 22, 2012 at 18:40 UTC
23119ffb4ea91cdf30016254df60e1adc64b478c
1 file changed
+2
-2
block-sha1/sha1.c
+2
-2
@@ -100,8 +100,8 @@
100
* Where do we get the source from? The first 16 iterations get it from
101
* the input data, the next mix it from the 512-bit array.
102
*/
103
-#define SHA_SRC(t) get_be32((unsigned char *) block + t*4)
104
-#define SHA_MIX(t) SHA_ROL(W(t+13) ^ W(t+8) ^ W(t+2) ^ W(t), 1)
103
+#define SHA_SRC(t) get_be32((unsigned char *) block + (t)*4)
104
+#define SHA_MIX(t) SHA_ROL(W((t)+13) ^ W((t)+8) ^ W((t)+2) ^ W(t), 1);
105
106
#define SHA_ROUND(t, input, fn, constant, A, B, C, D, E) do { \
107
unsigned int TEMP = input(t); setW(t, TEMP); \