diff: avoid redundantly clearing a flag
No code in diff.c sets DIFF_SYMBOL_MOVED_LINE except in mark_color_as_moved(), so it is redundant to clear it for the current line. Therefore, clear it only for previous lines. This makes a refactoring in a subsequent patch easier. Signed-off-by: Jonathan Tan <jonathantanmy@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jonathan Tan committed
Aug 11, 2017 at 15:49 UTC
23b65f9528a1fa19619d1dcb59932cc55075808c
1 file changed
+1
-1
diff.c
+1
-1
@@ -898,7 +898,7 @@ static void mark_color_as_moved(struct diff_options *o,
898
if (!match) {
899
if (block_length < COLOR_MOVED_MIN_BLOCK_LENGTH &&
900
o->color_moved != COLOR_MOVED_PLAIN) {
901
- for (i = 0; i < block_length + 1; i++) {
901
+ for (i = 1; i < block_length + 1; i++) {
902
l = &o->emitted_symbols->buf[n - i];
903
l->flags &= ~DIFF_SYMBOL_MOVED_LINE;
904
}