t3900: do not reference numbered arguments from the test script

The call to test_expect_success is nested inside a function, whose arguments the test code wants to access. But it is not specified that any unexpanded $1, $2, $3, etc in the test code will access the surrounding function's arguments. Rather, they will access the arguments of the function that happens to eval the test code. In this case, the reference is intended to supply '-m message' to a call of 'git commit --squash'. Remove it because -m is optional and the test case does not check for it. There are tests in t7500 that check combinations of --squash and -m. Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Johannes Sixt committed Aug 11, 2011 at 09:05 UTC 23ce5c39dc7b530a71d26598af7d93b01d182534
1 file changed +2 -2
t/t3900-i18n-commit.sh
+2 -2
@@ -147,7 +147,7 @@ test_commit_autosquash_flags () {
147 git commit -a -m "intermediate commit" &&
148 test_tick &&
149 echo $H $flag >>F &&
150 - git commit -a --$flag HEAD~1 $3 &&
150 + git commit -a --$flag HEAD~1 &&
151 E=$(git cat-file commit '$H-$flag' |
152 sed -ne "s/^encoding //p") &&
153 test "z$E" = "z$H" &&
@@ -160,6 +160,6 @@ test_commit_autosquash_flags () {
160
161 test_commit_autosquash_flags eucJP fixup
162
163 -test_commit_autosquash_flags ISO-2022-JP squash '-m "squash message"'
163 +test_commit_autosquash_flags ISO-2022-JP squash
164
165 test_done