t/README: document writing concurrency-safe helpers

The apply-one-time-script.sh and http-429.sh fixes addressed the same underlying problem: a test helper assuming it has exclusive access to a file when the web server can run it for several requests at once. The atomic idioms that avoid this are not specific to CGI or to HTTP, so document them generally, alongside the other guidance for writing tests, and leave a pointer from the lib-httpd helper list rather than a local comment. The note covers the anti-pattern (a "test -f" then a separate act) and the two safe operations (mkdir to elect a winner, rename to consume a one-shot marker), citing Git's own lockfile machinery and make_symlink() as precedent. Signed-off-by: Michael Montalbo <mmontalbo@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Michael Montalbo committed Jul 10, 2026 at 17:30 UTC 23e68ead57e50f8de3a368f7f1a07b236f2b344c
2 files changed +35
t/README
+32
@@ -854,6 +854,38 @@ from the test harness library. At the end of the script, call
854 'test_done'.
855
856
857 +Writing concurrency-safe helpers
858 +--------------------------------
859 +
860 +Some test code runs concurrently: a test may background work with '&',
861 +and the helper scripts installed for the web server (in t/lib-httpd) are
862 +run once per request, so the same script can execute for several
863 +requests at once. Such code cannot assume it has exclusive access to a
864 +file.
865 +
866 +When exactly one of several concurrent processes needs to "win" a
867 +decision, a single atomic filesystem operation can make it, rather than
868 +a check followed by a separate action. A "test -f X" then "touch X"
869 +(or "rm X") races: two processes can both pass the check before either
870 +acts. Two atomic operations avoid this:
871 +
872 + - "mkdir dir", which fails if the directory already exists, so that
873 + exactly one caller wins, electing a first or only request (see
874 + t/lib-httpd/http-429.sh).
875 +
876 + - "mv src dst" (rename), which fails if the source is gone, so that
877 + exactly one caller consumes it, claiming a planted one-shot marker
878 + (see t/lib-httpd/apply-one-time-script.sh).
879 +
880 +A "$$" suffix on per-request scratch files keeps concurrent invocations
881 +from clobbering each other's fixed-name files.
882 +
883 +This is a standard shell locking idiom, and the same reasoning behind
884 +Git's own lockfile machinery, which creates its lock with O_CREAT|O_EXCL,
885 +and make_symlink() in t/test-lib.sh, which uses an mkdir lock: an atomic
886 +operation whose failure indicates that another process got there first.
887 +
888 +
889 Test harness library
890 --------------------
891
t/lib-httpd.sh
+3
@@ -159,6 +159,9 @@ prepare_httpd() {
159 mkdir -p "$HTTPD_DOCUMENT_ROOT_PATH"
160 cp "$TEST_PATH"/passwd "$HTTPD_ROOT_PATH"
161 cp "$TEST_PATH"/proxy-passwd "$HTTPD_ROOT_PATH"
162 + # The web server can run any of these CGI scripts for two requests at
163 + # once; a helper that keeps state between requests must do so with an
164 + # atomic operation. See "Writing concurrency-safe helpers" in t/README.
165 install_script incomplete-length-upload-pack-v2-http.sh
166 install_script incomplete-body-upload-pack-v2-http.sh
167 install_script error-no-report.sh