@matheusbsbs / matheus-bagliano / commits / 243bfd3399
Fork 0

SubmittingPatches: mention older C compiler compatibility

We do not appreciate C99 initializers, declarations after statements, or "0" instead of "NULL". Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Signed-off-by: Junio C Hamano <junkio@cox.net>

Johannes Schindelin committed May 21, 2007 at 13:48 UTC 243bfd33997484ee8ea2450f1910306f7138193b
1 file changed +13
Documentation/SubmittingPatches
+13
@@ -62,6 +62,19 @@ in templates/hooks--pre-commit. To help ensure this does not happen,
62 run git diff --check on your changes before you commit.
63
64
65 +(1a) Try to be nice to older C compilers
66 +
67 +We try to support wide range of C compilers to compile
68 +git with. That means that you should not use C99 initializers, even
69 +if a lot of compilers grok it.
70 +
71 +Also, variables have to be declared at the beginning of the block
72 +(you can check this with gcc, using the -Wdeclaration-after-statement
73 +option).
74 +
75 +Another thing: NULL pointers shall be written as NULL, not as 0.
76 +
77 +
78 (2) Generate your patch using git tools out of your commits.
79
80 git based diff tools (git, Cogito, and StGIT included) generate