@matheusbsbs / matheus-bagliano / commits / 243caa8982

t5314: check exit code of "git"

Amend the test added in [1] to check the exit code of the "git" invocations. An in-flight change[2] introduced a memory leak in these invocations, which went undetected unless we were running under "GIT_TEST_SANITIZE_LEAK_LOG=true". Note that the in-flight change made 8 test files fail, but as far as I can tell only this one would have had its exit code hidden unless under "GIT_TEST_SANITIZE_LEAK_LOG=true". The rest would be caught without it. We could pick other variable names here than "ln%d", e.g. "commit", "dummy_blob" and "file_blob", but having the "rev-parse" invocations aligned makes the difference between them more readable, so let's pick "ln%d". 1. 4cf2143e029 (pack-objects: break delta cycles before delta-search phase, 2016-08-11) 2. https://lore.kernel.org/git/221128.868rjvmi3l.gmgdl@evledraar.gmail.com/ 3. faececa53f9 (test-lib: have the "check" mode for SANITIZE=leak consider leak logs, 2022-07-28) Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Ævar Arnfjörð Bjarmason committed Nov 28, 2022 at 15:18 UTC 243caa898284413c2e53388787c8c6b599b91fb4

1 file changed +10 -7

t/t5314-pack-cycle-detection.sh

+10 -7

@@ -63,13 +63,16 @@ TEST_PASSES_SANITIZE_LEAK=true

63 # Note that the two variants of "file" must be similar enough to convince git

64 # to create the delta.

65 make_pack () {

66 - {

67 - printf '%s\n' "-$(git rev-parse $2)"

68 - printf '%s dummy\n' "$(git rev-parse $1:dummy)"

69 - printf '%s file\n' "$(git rev-parse $1:file)"

70 - } |

71 - git pack-objects --stdout |

72 - git index-pack --stdin --fix-thin

66 + ln1=$(git rev-parse "$2") &&

67 + ln2=$(git rev-parse "$1:dummy") &&

68 + ln3=$(git rev-parse "$1:file") &&

69 + cat >list <<-EOF

70 + -$ln1

71 + $ln2 dummy

72 + $ln3 file

73 + EOF

74 + git pack-objects --stdout <list >pack &&

75 + git index-pack --stdin --fix-thin <pack

76 }

78 test_expect_success 'setup' '