@matheusbsbs / matheus-bagliano / commits / 2456374e78

cmake/vcxproj: stop special-casing `remote-ext`

When the `vcxproj` target was introduced in `config.mak.uname` to allow building Git with the Visual C toolchain, the `git remote-ext` command was always executed in its dashed form. Therefore, it was impossible to pass the test suite unless that command existed in its dashed form, and we had to special-case this. Later, when the `vcxproj` target got out of fashion because Visual Studio gained native support for CMake builds, this special-casing was copied without questioning it. But as of 675df192c5f (transport-helper: do not run git-remote-ext etc. in dashed form, 2020-08-26), the reason for this special-casing no longer exists. So let's just drop it. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Johannes Schindelin committed Dec 17, 2024 at 17:32 UTC 2456374e782b83c4087cc819ea019ea92b535bf7
2 files changed +1 -5
config.mak.uname
-4
@@ -819,10 +819,6 @@ vcxproj:
819 sed -i 's|\(git\)-\([-a-z]*\)\.exe"|\1.exe" \2|g' \
820 bin-wrappers/git-{receive-pack,upload-archive}
821 git add -f $(test_bindir_programs)
822 - # remote-ext is a builtin, but invoked as if it were external
823 - sed 's|receive-pack|remote-ext|g' \
824 - <bin-wrappers/git-receive-pack >bin-wrappers/git-remote-ext
825 - git add -f bin-wrappers/git-remote-ext
822
823 # Add templates
824 $(MAKE) -C templates
contrib/buildsystems/CMakeLists.txt
+1 -1
@@ -1082,7 +1082,7 @@ endif()
1082
1083 #wrapper scripts
1084 set(wrapper_scripts
1085 - git git-upload-pack git-receive-pack git-upload-archive git-shell git-remote-ext scalar)
1085 + git git-upload-pack git-receive-pack git-upload-archive git-shell scalar)
1086
1087 set(wrapper_test_scripts
1088 test-fake-ssh test-tool)