t5318: replace use of /dev/zero with generate_zero_bytes
There are platforms (e.g. NonStop) that lack /dev/zero; use the generate_zero_bytes helper we just introduced to append stream of NULs at the end of the file. The original, even though it uses "dd seek=... count=..." to make it look like it is overwriting the middle part of an existing file, has truncated the file before this step with another use of "dd", which may make it tricky to see why this rewrite is a correct one. Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Randall S. Becker committed
Feb 9, 2019 at 13:59 UTC
24b451e77c7d3a62624a309111e8933c7f9f10ba
1 file changed
+1
-1
t/t5318-commit-graph.sh
+1
-1
@@ -383,7 +383,7 @@ corrupt_graph_and_verify() {
383
cp $objdir/info/commit-graph commit-graph-backup &&
384
printf "$data" | dd of="$objdir/info/commit-graph" bs=1 seek="$pos" conv=notrunc &&
385
dd of="$objdir/info/commit-graph" bs=1 seek="$zero_pos" count=0 &&
386
- dd if=/dev/zero of="$objdir/info/commit-graph" bs=1 seek="$zero_pos" count=$(($orig_size - $zero_pos)) &&
386
+ generate_zero_bytes $(($orig_size - $zero_pos)) >>"$objdir/info/commit-graph" &&
387
test_must_fail git commit-graph verify 2>test_err &&
388
grep -v "^+" test_err >err &&
389
test_i18ngrep "$grepstr" err