doc: MyFirstContribution: fix cmd placement instructions
Using the pull command instead of push is more accurate when giving instructions on placing the psuh command in alphabetical order. Signed-off-by: Pedro Sousa <pedroteosousa@gmail.com> Acked-by: Philip Oakley <philipoakley@iee.email> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Pedro Sousa committed
Sep 26, 2019 at 16:05 UTC
24c681794f125b5be27d2d2cfb9b28cf3ff3ee01
1 file changed
+5
-5
Documentation/MyFirstContribution.txt
+5
-5
@@ -97,8 +97,8 @@ int cmd_psuh(int argc, const char **argv, const char *prefix)
97
----
98
99
We'll also need to add the declaration of psuh; open up `builtin.h`, find the
100
-declaration for `cmd_push`, and add a new line for `psuh` immediately before it,
101
-in order to keep the declarations sorted:
100
+declaration for `cmd_pull`, and add a new line for `psuh` immediately before it,
101
+in order to keep the declarations alphabetically sorted:
102
103
----
104
int cmd_psuh(int argc, const char **argv, const char *prefix);
@@ -123,7 +123,7 @@ int cmd_psuh(int argc, const char **argv, const char *prefix)
123
}
124
----
125
126
-Let's try to build it. Open `Makefile`, find where `builtin/push.o` is added
126
+Let's try to build it. Open `Makefile`, find where `builtin/pull.o` is added
127
to `BUILTIN_OBJS`, and add `builtin/psuh.o` in the same way next to it in
128
alphabetical order. Once you've done so, move to the top-level directory and
129
build simply with `make`. Also add the `DEVELOPER=1` variable to turn on
@@ -149,7 +149,7 @@ a `cmd_struct` to the `commands[]` array. `struct cmd_struct` takes a string
149
with the command name, a function pointer to the command implementation, and a
150
setup option flag. For now, let's keep mimicking `push`. Find the line where
151
`cmd_push` is registered, copy it, and modify it for `cmd_psuh`, placing the new
152
-line in alphabetical order.
152
+line in alphabetical order (immediately before `cmd_pull`).
153
154
The options are documented in `builtin.h` under "Adding a new built-in." Since
155
we hope to print some data about the user's current workspace context later,
@@ -167,7 +167,7 @@ Check it out! You've got a command! Nice work! Let's commit this.
167
168
`git status` reveals modified `Makefile`, `builtin.h`, and `git.c` as well as
169
untracked `builtin/psuh.c` and `git-psuh`. First, let's take care of the binary,
170
-which should be ignored. Open `.gitignore` in your editor, find `/git-push`, and
170
+which should be ignored. Open `.gitignore` in your editor, find `/git-pull`, and
171
add an entry for your new command in alphabetical order:
172
173
----