t1800: correct test to handle Cygwin

On Cygwin, when failing to spawn a process using start_command, Git outputs the same error as on Linux systems, rather than using the GIT_WINDOWS_NATIVE-specific error output. The WINDOWS test prerequisite is set in both Cygwin and native Windows environments, which means it's not appropriate to use to anticipate the error output from start_command. Instead, use the MINGW test prerequisite, which is only set for Git in native Windows environments, and not for Cygwin. Signed-off-by: Adam Dinwoodie <adam@dinwoodie.org> Helped-by: Đoàn Trần Công Danh <congdanhqx@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Adam Dinwoodie committed Sep 15, 2022 at 08:57 UTC 255a6f91ae4600ee2d257670477caf97b7986470
1 file changed +3 -3
t/t1800-hook.sh
+3 -3
@@ -157,9 +157,9 @@ test_expect_success 'git hook run a hook with a bad shebang' '
157 write_script bad-hooks/test-hook "/bad/path/no/spaces" </dev/null &&
158
159 # TODO: We should emit the same (or at least a more similar)
160 - # error on Windows and !Windows. See the OS-specific code in
161 - # start_command()
162 - if test_have_prereq !WINDOWS
160 + # error on MINGW (essentially Git for Windows) and all other
161 + # platforms.. See the OS-specific code in start_command()
162 + if test_have_prereq !MINGW
163 then
164 cat >expect <<-\EOF
165 fatal: cannot run bad-hooks/test-hook: ...