push tests: fix logic error in "push" test assertion
Fix a logic error that's been here since this test was added in dbfeddb12e ("push: require force for refs under refs/tags/", 2012-11-29). The intent of this test is to force-create a new tag pointing to HEAD~, and then assert that pushing it doesn't work without --force. Instead, the code was not creating a new tag at all, and then failing to push the previous tag for the unrelated reason of providing a refspec that doesn't make any sense. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Jul 31, 2018 at 13:07 UTC
25f74f5234ffe2f0100b06c657fedb9cc7774ed3
1 file changed
+2
-2
t/t5516-fetch-push.sh
+2
-2
@@ -979,8 +979,8 @@ test_expect_success 'push requires --force to update lightweight tag' '
979
git tag -f testTag &&
980
test_must_fail git push ../child2 testTag &&
981
git push --force ../child2 testTag &&
982
- git tag -f testTag &&
983
- test_must_fail git push ../child2 testTag HEAD~ &&
982
+ git tag -f testTag HEAD~ &&
983
+ test_must_fail git push ../child2 testTag &&
984
git push --force ../child2 testTag
985
)
986
'