ls-files: add missing string_list_clear()
Fix a memory leak that's been here ever since 72aeb18772d (clean.c, ls-files.c: respect encapsulation of exclude_list_groups, 2013-01-16), we dup'd the argument in option_parse_exclude(), but never freed the string_list. This makes almost all of t3001-ls-files-others-exclude.sh pass (it had a lot of failures before). Let's mark it as passing with TEST_PASSES_SANITIZE_LEAK=true, and then exclude the tests that still failed with a !SANITIZE_LEAK prerequisite check until we fix those leaks. We can still see the failed tests under GIT_TEST_FAIL_PREREQS=true. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Oct 7, 2021 at 12:01 UTC
272f0a574d97ecd245fb0a9ab63c436e8cfe6a06
2 files changed
+4
-2
builtin/ls-files.c
+1
@@ -781,6 +781,7 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)
781
ret = 1;
782
}
783
784
+ string_list_clear(&exclude_list, 0);
785
dir_clear(&dir);
786
free(max_prefix);
787
return ret;
t/t3001-ls-files-others-exclude.sh
+3
-2
@@ -8,6 +8,7 @@ test_description='git ls-files --others --exclude
8
This test runs git ls-files --others and tests --exclude patterns.
9
'
10
11
+TEST_PASSES_SANITIZE_LEAK=true
12
. ./test-lib.sh
13
14
rm -fr one three
@@ -102,7 +103,7 @@ test_expect_success \
103
>output &&
104
test_cmp expect output'
105
105
-test_expect_success 'restore gitignore' '
106
+test_expect_success !SANITIZE_LEAK 'restore gitignore' '
107
git checkout --ignore-skip-worktree-bits $allignores &&
108
rm .git/index
109
'
@@ -125,7 +126,7 @@ cat > expect << EOF
126
# three/
127
EOF
128
128
-test_expect_success 'git status honors core.excludesfile' \
129
+test_expect_success !SANITIZE_LEAK 'git status honors core.excludesfile' \
130
'test_cmp expect output'
131
132
test_expect_success 'trailing slash in exclude allows directory match(1)' '