@matheusbsbs / matheus-bagliano / commits / 274bfa7f28

commit-graph: free write-context entries before overwriting

When writing a split graph file, we replace the final element of the commit_graph_hash_after and commit_graph_filenames_after arrays. But since these are allocated strings, we need to free them before overwriting to avoid leaking the old string. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Oct 3, 2023 at 16:30 UTC 274bfa7f28fea96fafa114f2508ebef53735d7b6

1 file changed +2

commit-graph.c

@@ -2065,9 +2065,11 @@ static int write_commit_graph_file(struct write_commit_graph_context *ctx)

2065 free(graph_name);

2066 }

2067

2068 + free(ctx->commit_graph_hash_after[ctx->num_commit_graphs_after - 1]);

2069 ctx->commit_graph_hash_after[ctx->num_commit_graphs_after - 1] = xstrdup(hash_to_hex(file_hash));

2070 final_graph_name = get_split_graph_filename(ctx->odb,

2071 ctx->commit_graph_hash_after[ctx->num_commit_graphs_after - 1]);

2072 + free(ctx->commit_graph_filenames_after[ctx->num_commit_graphs_after - 1]);

2073 ctx->commit_graph_filenames_after[ctx->num_commit_graphs_after - 1] = final_graph_name;

2074

2075 result = rename(ctx->graph_name, final_graph_name);