free ref string returned by dwim_ref
A call to "dwim_ref(name, len, flags, &ref)" will allocate a new string in "ref" to return the exact ref we found. We do not consistently free it in all code paths, leading to small leaks. The worst is in get_sha1_basic, which may be called many times (e.g., by "cat-file --batch"), though it is relatively unlikely, as it only triggers on a bogus reflog specification. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jul 24, 2014 at 00:41 UTC
28b3563241ac13733781fb0bada37f776a39f43d
3 files changed
+5
-1
builtin/rev-parse.c
+1
@@ -150,6 +150,7 @@ static void show_rev(int type, const unsigned char *sha1, const char *name)
150
error("refname '%s' is ambiguous", name);
151
break;
152
}
153
+ free(full);
154
} else {
155
show_with_type(type, name);
156
}
builtin/show-branch.c
+1
@@ -779,6 +779,7 @@ int cmd_show_branch(int ac, const char **av, const char *prefix)
779
sprintf(nth_desc, "%s@{%d}", *av, base+i);
780
append_ref(nth_desc, sha1, 1);
781
}
782
+ free(ref);
783
}
784
else if (all_heads + all_remotes)
785
snarf_refs(all_heads, all_remotes);
sha1_name.c
+3
-1
@@ -540,8 +540,10 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
540
char *tmp = xstrndup(str + at + 2, reflog_len);
541
at_time = approxidate_careful(tmp, &errors);
542
free(tmp);
543
- if (errors)
543
+ if (errors) {
544
+ free(real_ref);
545
return -1;
546
+ }
547
}
548
if (read_ref_at(real_ref, at_time, nth, sha1, NULL,
549
&co_time, &co_tz, &co_cnt)) {