@matheusbsbs / matheus-bagliano / commits / 29d8e21d6e

log test: skip a failing mkstemp() test under valgrind

Skip a test added in f1e3df31699 (t: increase test coverage of signature verification output, 2020-03-04) when running under valgrind. Due to valgrind's interception of mkstemp() this test will fail with: + pwd + TMPDIR=[...]/t/trash directory.t4202-log/bogus git log --show-signature -n1 plain-fail ==7696== VG_(mkstemp): failed to create temp file: [...]/t/trash directory.t4202-log/bogus/valgrind_proc_7696_cmdline_d545ddcf [... 10 more similar lines omitted ..] valgrind: Startup or configuration error: valgrind: Can't create client cmdline file in [...]/t/trash directory.t4202-log/bogus/valgrind_proc_7696_cmdline_6e542d1d valgrind: Unable to start up properly. Giving up. error: last command exited with $?=1 Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Ævar Arnfjörð Bjarmason committed May 12, 2022 at 15:32 UTC 29d8e21d6e97d5363233a960e7730e0afc26a8b1
1 file changed +7 -4
t/t4202-log.sh
+7 -4
@@ -1992,10 +1992,13 @@ test_expect_success GPG 'log --show-signature for merged tag with GPG failure' '
1992 git tag -s -m signed_tag_msg signed_tag_fail &&
1993 git checkout plain-fail &&
1994 git merge --no-ff -m msg signed_tag_fail &&
1995 - TMPDIR="$(pwd)/bogus" git log --show-signature -n1 plain-fail >actual &&
1996 - grep "^merged tag" actual &&
1997 - grep "^No signature" actual &&
1998 - ! grep "^gpg: Signature made" actual
1995 + if ! test_have_prereq VALGRIND
1996 + then
1997 + TMPDIR="$(pwd)/bogus" git log --show-signature -n1 plain-fail >actual &&
1998 + grep "^merged tag" actual &&
1999 + grep "^No signature" actual &&
2000 + ! grep "^gpg: Signature made" actual
2001 + fi
2002 '
2003
2004 test_expect_success GPGSM 'log --graph --show-signature for merged tag x509' '