branch: error message checking out a branch in use
Let's update the error message we show when the user tries to check out a branch which is being used in another worktree, following the guideline reasoned in 4970bedef2 (branch: update the message to refuse touching a branch in-use, 2023-07-21). Signed-off-by: Rubén Justo <rjusto@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Rubén Justo committed
Aug 7, 2023 at 22:42 UTC
2a499264d39c663517a8e4fe7f3abb55fc4a829a
3 files changed
+4
-3
branch.c
+1
-1
@@ -838,7 +838,7 @@ void die_if_checked_out(const char *branch, int ignore_current_worktree)
838
839
if (is_shared_symref(worktrees[i], "HEAD", branch)) {
840
skip_prefix(branch, "refs/heads/", &branch);
841
- die(_("'%s' is already checked out at '%s'"),
841
+ die(_("'%s' is already used by worktree at '%s'"),
842
branch, worktrees[i]->path);
843
}
844
}
t/t2400-worktree-add.sh
+2
-1
@@ -121,7 +121,8 @@ test_expect_success '"add" worktree creating new branch' '
121
test_expect_success 'die the same branch is already checked out' '
122
(
123
cd here &&
124
- test_must_fail git checkout newmain
124
+ test_must_fail git checkout newmain 2>actual &&
125
+ grep "already used by worktree at" actual
126
)
127
'
128
t/t3400-rebase.sh
+1
-1
@@ -421,7 +421,7 @@ test_expect_success 'refuse to switch to branch checked out elsewhere' '
421
git checkout main &&
422
git worktree add wt &&
423
test_must_fail git -C wt rebase main main 2>err &&
424
- test_i18ngrep "already checked out" err
424
+ test_i18ngrep "already used by worktree at" err
425
'
426
427
test_expect_success MINGW,SYMLINKS_WINDOWS 'rebase when .git/logs is a symlink' '