reftable: change the type of array indices to 'size_t' in reftable/pq.c
The variables 'i', 'j', 'k' and 'min' are used as indices for 'pq->heap', which is an array. Additionally, 'pq->len' is of type 'size_t' and is often used to assign values to these variables. Hence, change the type of these variables from 'int' to 'size_t'. Mentored-by: Patrick Steinhardt <ps@pks.im> Mentored-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Chandra Pratap committed
Aug 1, 2024 at 16:29 UTC
2a85906348d324056f8d147a51156d9901a9675f
1 file changed
+6
-6
reftable/pq.c
+6
-6
@@ -22,15 +22,15 @@ int pq_less(struct pq_entry *a, struct pq_entry *b)
22
23
struct pq_entry merged_iter_pqueue_remove(struct merged_iter_pqueue *pq)
24
{
25
- int i = 0;
25
+ size_t i = 0;
26
struct pq_entry e = pq->heap[0];
27
pq->heap[0] = pq->heap[pq->len - 1];
28
pq->len--;
29
30
while (i < pq->len) {
31
- int min = i;
32
- int j = 2 * i + 1;
33
- int k = 2 * i + 2;
31
+ size_t min = i;
32
+ size_t j = 2 * i + 1;
33
+ size_t k = 2 * i + 2;
34
if (j < pq->len && pq_less(&pq->heap[j], &pq->heap[i]))
35
min = j;
36
if (k < pq->len && pq_less(&pq->heap[k], &pq->heap[min]))
@@ -46,14 +46,14 @@ struct pq_entry merged_iter_pqueue_remove(struct merged_iter_pqueue *pq)
46
47
void merged_iter_pqueue_add(struct merged_iter_pqueue *pq, const struct pq_entry *e)
48
{
49
- int i = 0;
49
+ size_t i = 0;
50
51
REFTABLE_ALLOC_GROW(pq->heap, pq->len + 1, pq->cap);
52
pq->heap[pq->len++] = *e;
53
54
i = pq->len - 1;
55
while (i > 0) {
56
- int j = (i - 1) / 2;
56
+ size_t j = (i - 1) / 2;
57
if (pq_less(&pq->heap[j], &pq->heap[i]))
58
break;
59
SWAP(pq->heap[j], pq->heap[i]);