t5312: drop "verbose" helper
t5312 has several uses of the "verbose" helper, as described in 8ad1652418 (t5304: use helper to report failure of "test foo = bar", 2014-10-10). Back then the "-x" trace option for tests was new, and was not as pleasant to use (e.g., some tests failed under "-x", we did not support BASH_XTRACEFD, etc). These days it is clear that "-x" is the preferred way to get extra output, and we don't need to mark up individual tests. Let's get rid of the uses of "verbose" here, as one step toward eradicating it totally. Signed-off-by: Jeff King <peff@peff.net> Reviewed-by: Jonathan Tan <jonathantanmy@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Sep 24, 2021 at 14:35 UTC
2ac0cbc9b0bf9236b34eff4aa0160f5cfc3606c4
1 file changed
+5
-5
t/t5312-prune-corruption.sh
+5
-5
@@ -31,21 +31,21 @@ test_expect_success 'create history reachable only from a bogus-named ref' '
31
test_expect_success 'pruning does not drop bogus object' '
32
test_when_finished "git hash-object -w -t commit saved" &&
33
test_might_fail git prune --expire=now &&
34
- verbose git cat-file -e $bogus
34
+ git cat-file -e $bogus
35
'
36
37
test_expect_success 'put bogus object into pack' '
38
git tag reachable $bogus &&
39
git repack -ad &&
40
git tag -d reachable &&
41
- verbose git cat-file -e $bogus
41
+ git cat-file -e $bogus
42
'
43
44
test_expect_success 'destructive repack keeps packed object' '
45
test_might_fail git repack -Ad --unpack-unreachable=now &&
46
- verbose git cat-file -e $bogus &&
46
+ git cat-file -e $bogus &&
47
test_might_fail git repack -ad &&
48
- verbose git cat-file -e $bogus
48
+ git cat-file -e $bogus
49
'
50
51
# subsequent tests will have different corruptions
@@ -78,7 +78,7 @@ test_expect_success 'create history with missing tip commit' '
78
test_expect_success 'pruning with a corrupted tip does not drop history' '
79
test_when_finished "git hash-object -w -t commit saved" &&
80
test_might_fail git prune --expire=now &&
81
- verbose git cat-file -e $recoverable
81
+ git cat-file -e $recoverable
82
'
83
84
test_expect_success 'pack-refs does not silently delete broken loose ref' '