doc-diff: don't `cd_to_toplevel`

`usage` tries to call $0, which might very well be "./doc-diff", so if we `cd_to_toplevel` before calling `usage`, we'll end with an error to the effect of "./doc-diff: not found" rather than a friendly `doc-diff -h` output. This regressed in ad51743007 ("doc-diff: add --clean mode to remove temporary working gunk", 2018-08-31) where we moved the call to `cd_to_toplevel` to much earlier. A general fix might be to teach git-sh-setup to save away the absolute path for $0 and then use that, instead. I'm not aware of any portable way of doing that, see, e.g., d2addc3b96 ("t7800: readlink may not be available", 2016-05-31). An early version of this patch moved `cd_to_toplevel` back to where it was before ad51743007 and taught the "--clean" code to cd on its own. But let's try instead to get rid of the cd-ing entirely. We don't really need it and we can work with absolute paths instead. There's just one use of $PWD that we need to adjust by simply dropping it. Suggested-by: Jeff King <peff@peff.net> Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Martin Ågren committed Feb 4, 2019 at 21:50 UTC 2afe9278a2c1930538ea465955174abf82def3e5
1 file changed +2 -3
Documentation/doc-diff
+2 -3
@@ -39,8 +39,7 @@ do
39 shift
40 done
41
42 -cd_to_toplevel
43 -tmp=Documentation/tmp-doc-diff
42 +tmp="$(git rev-parse --show-toplevel)/Documentation/tmp-doc-diff" || exit 1
43
44 if test -n "$clean"
45 then
@@ -109,7 +108,7 @@ render_tree () {
108 make -j$parallel -C "$tmp/worktree" \
109 GIT_VERSION=omitted \
110 SOURCE_DATE_EPOCH=0 \
112 - DESTDIR="$PWD/$tmp/installed/$1+" \
111 + DESTDIR="$tmp/installed/$1+" \
112 install-man &&
113 mv "$tmp/installed/$1+" "$tmp/installed/$1"
114 fi &&