ref-filter: drop broken-ref code entirely
Now that none of our callers passes the INCLUDE_BROKEN flag, we can drop it entirely, along with the code to plumb it through to the for_each_fullref_in() functions. Signed-off-by: Jeff King <peff@peff.net> Reviewed-by: Jonathan Tan <jonathantanmy@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Sep 24, 2021 at 14:48 UTC
2d653c50364aeccb604f6b4680190824debf637a
2 files changed
+4
-8
ref-filter.c
+4
-7
@@ -2405,13 +2405,10 @@ int filter_refs(struct ref_array *array, struct ref_filter *filter, unsigned int
2405
{
2406
struct ref_filter_cbdata ref_cbdata;
2407
int ret = 0;
2408
- unsigned int broken = 0;
2408
2409
ref_cbdata.array = array;
2410
ref_cbdata.filter = filter;
2411
2413
- if (type & FILTER_REFS_INCLUDE_BROKEN)
2414
- broken = 1;
2412
filter->kind = type & FILTER_REFS_KIND_MASK;
2413
2414
init_contains_cache(&ref_cbdata.contains_cache);
@@ -2428,13 +2425,13 @@ int filter_refs(struct ref_array *array, struct ref_filter *filter, unsigned int
2425
* of filter_ref_kind().
2426
*/
2427
if (filter->kind == FILTER_REFS_BRANCHES)
2431
- ret = for_each_fullref_in("refs/heads/", ref_filter_handler, &ref_cbdata, broken);
2428
+ ret = for_each_fullref_in("refs/heads/", ref_filter_handler, &ref_cbdata, 0);
2429
else if (filter->kind == FILTER_REFS_REMOTES)
2433
- ret = for_each_fullref_in("refs/remotes/", ref_filter_handler, &ref_cbdata, broken);
2430
+ ret = for_each_fullref_in("refs/remotes/", ref_filter_handler, &ref_cbdata, 0);
2431
else if (filter->kind == FILTER_REFS_TAGS)
2435
- ret = for_each_fullref_in("refs/tags/", ref_filter_handler, &ref_cbdata, broken);
2432
+ ret = for_each_fullref_in("refs/tags/", ref_filter_handler, &ref_cbdata, 0);
2433
else if (filter->kind & FILTER_REFS_ALL)
2437
- ret = for_each_fullref_in_pattern(filter, ref_filter_handler, &ref_cbdata, broken);
2434
+ ret = for_each_fullref_in_pattern(filter, ref_filter_handler, &ref_cbdata, 0);
2435
if (!ret && (filter->kind & FILTER_REFS_DETACHED_HEAD))
2436
head_ref(ref_filter_handler, &ref_cbdata);
2437
}
ref-filter.h
-1
@@ -13,7 +13,6 @@
13
#define QUOTE_PYTHON 4
14
#define QUOTE_TCL 8
15
16
-#define FILTER_REFS_INCLUDE_BROKEN 0x0001
16
#define FILTER_REFS_TAGS 0x0002
17
#define FILTER_REFS_BRANCHES 0x0004
18
#define FILTER_REFS_REMOTES 0x0008