gitweb: Fix two 'uninitialized value' warnings in git_tree()

If we did try to access nonexistent directory or file, which means that git_get_hash_by_path() returns `undef`, uninitialized $hash variable was passed to 'open' call. Now we fail early with "404 Not Found - No such tree" error. (If we try to access something which does not resolve to tree-ish, for example a file / 'blob' object, the error will be caught later, as "404 Not Found - Reading tree failed" error). If we tried to use 'tree' action without $file_name ('f' parameter) set, which means either tree given by hash or a top tree (and we currently cannot distinguish between those two cases), we cannot print path breadcrumbs with git_print_page_path(). Fix this by moving call to git_print_page_path() inside conditional. Signed-off-by: Jakub Narebski <jnareb@gmail.com> Acked-by: Petr Baudis <pasky@suse.cz> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

Jakub Narebski committed Oct 2, 2008 at 16:50 UTC 2d7a3532c78bace2f3631ab0e594f713dcab9916

1 file changed +2 -1

gitweb/gitweb.perl

+2 -1

@@ -4421,6 +4421,7 @@ sub git_tree {

4421 $hash = $hash_base;

4422 }

4423 }

4424 + die_error(404, "No such tree") unless defined($hash);

4425 $/ = "\0";

4426 open my $fd, "-|", git_cmd(), "ls-tree", '-z', $hash

4427 or die_error(500, "Open git-ls-tree failed");

@@ -4461,8 +4462,8 @@ sub git_tree {

4462 if ($basedir ne '' && substr($basedir, -1) ne '/') {

4463 $basedir .= '/';

4464 }

4465 + git_print_page_path($file_name, 'tree', $hash_base);

4466 }

4465 - git_print_page_path($file_name, 'tree', $hash_base);

4467 print "<div class=\"page_body\">\n";

4468 print "<table class=\"tree\">\n";

4469 my $alternate = 1;