git-remote-mediawiki: update comments to reflect credential support
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Matthieu Moy committed
Jul 8, 2012 at 18:18 UTC
2da7830d5c3b0779fed6ac16008a6e380a99dd2e
1 file changed
+1
-6
contrib/mw-to-git/git-remote-mediawiki
+1
-6
@@ -26,9 +26,6 @@
26
# - Git renames could be turned into MediaWiki renames (see TODO
27
# below)
28
#
29
-# - login/password support requires the user to write the password
30
-# cleartext in a file (see TODO below).
31
-#
29
# - No way to import "one page, and all pages included in it"
30
#
31
# - Multiple remote MediaWikis have not been very well tested.
@@ -74,9 +71,7 @@ my @tracked_categories = split(/[ \n]/, run_git("config --get-all remote.". $rem
71
chomp(@tracked_categories);
72
73
my $wiki_login = run_git("config --get remote.". $remotename .".mwLogin");
77
-# TODO: ideally, this should be able to read from keyboard, but we're
78
-# inside a remote helper, so our stdin is connect to git, not to a
79
-# terminal.
74
+# Note: mwPassword is discourraged. Use the credential system instead.
75
my $wiki_passwd = run_git("config --get remote.". $remotename .".mwPassword");
76
my $wiki_domain = run_git("config --get remote.". $remotename .".mwDomain");
77
chomp($wiki_login);