imap-send: display port alongwith host when git credential is invoked
When requesting for passsword, git credential helper used to display only the host name. For example: Password for 'imaps://gargaditya08%40live.com@outlook.office365.com': Now, it will display the port along with the host name: Password for 'imaps://gargaditya08%40live.com@outlook.office365.com:993': This has been done to make credential helpers more specific for ports. Also, this behaviour will also mimic git send-email, which displays the port along with the host name when requesting for a password. Signed-off-by: Aditya Garg <gargaditya08@live.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Aditya Garg committed
Jun 20, 2025 at 12:10 UTC
2dacd35731d9d9947913eac991599ff000468cf3
1 file changed
+1
-1
imap-send.c
+1
-1
@@ -1082,7 +1082,7 @@ static void server_fill_credential(struct imap_server_conf *srvc, struct credent
1082
return;
1083
1084
cred->protocol = xstrdup(srvc->use_ssl ? "imaps" : "imap");
1085
- cred->host = xstrdup(srvc->host);
1085
+ cred->host = xstrfmt("%s:%d", srvc->host, srvc->port);
1086
1087
cred->username = xstrdup_or_null(srvc->user);
1088
cred->password = xstrdup_or_null(srvc->pass);