@matheusbsbs / matheus-bagliano / commits / 2ec30e71f4

ref-filter: simplify rstrip_ref_components() memory handling

We're stripping path components from the end of a string, which we do by assigning a NUL as we parse each component, shortening the string. This requires an extra temporary buffer to avoid munging our input string. But the way that we allocate the buffer is unusual. We have an extra "to_free" variable. Usually this is used when the access variable is conceptually const, like: const char *foo; char *to_free = NULL; if (...) foo = to_free = xstrdup(...); else foo = some_const_string; ... free(to_free); But that's not what's happening here. Our "start" variable always points to the allocated buffer, and to_free is redundant. Worse, it is marked as const itself, requiring a cast when we free it. Let's drop to_free entirely, and mark "start" as non-const, making the memory handling more clear. As a bonus, this also silences a warning from glibc-2.43 that our call to strrchr() implicitly strips away the const-ness of "start". Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Feb 15, 2026 at 04:05 UTC 2ec30e71f44233b9afceda0f2992029674187674

1 file changed +2 -3

ref-filter.c

+2 -3

@@ -2213,13 +2213,12 @@ static const char *lstrip_ref_components(const char *refname, int len)

2213 static const char *rstrip_ref_components(const char *refname, int len)

2214 {

2215 int remaining = normalize_component_count(refname, len);

2216 - const char *start = xstrdup(refname);

2217 - const char *to_free = start;

2216 + char *start = xstrdup(refname);

2217

2218 while (remaining-- > 0) {

2219 char *p = strrchr(start, '/');

2220 if (!p) {

2222 - free((char *)to_free);

2221 + free(start);

2222 return xstrdup("");

2223 } else

2224 p[0] = '\0';