sequencer: make rearrange_squash() a bit more obvious

There are some commands that have to be skipped from rearranging by virtue of not handling any commits. However, the logic was not quite obvious: it skipped commands based on their position in the enum todo_command. Instead, let's make it explicit that we skip all commands that do not handle any commit. With one exception: the `drop` command, because it, well, drops the commit and is therefore not eligible to rearranging. Note: this is a bit academic at the moment because the only time we call `rearrange_squash()` is directly after generating the todo list, when we have nothing but `pick` commands anyway. However, the upcoming `merge` command *will* want to be handled by that function, and it *can* handle commits. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Johannes Schindelin committed Apr 25, 2018 at 14:28 UTC 2f6b1d13aa730901fe328fc2d88f208ea44d4f9e
1 file changed +1 -1
sequencer.c
+1 -1
@@ -3403,7 +3403,7 @@ int rearrange_squash(void)
3403 struct subject2item_entry *entry;
3404
3405 next[i] = tail[i] = -1;
3406 - if (item->command >= TODO_EXEC) {
3406 + if (!item->commit || item->command == TODO_DROP) {
3407 subjects[i] = NULL;
3408 continue;
3409 }