@matheusbsbs / matheus-bagliano / commits / 31216ee28a

t-reftable-block: use block_iter_reset() instead of block_iter_close()

block_iter_reset() restores a block iterator to its state at the time of initialization without freeing any memory while block_iter_close() deallocates the memory for the iterator. In the current testing setup, a block iterator is allocated and deallocated for every iteration of a loop, which hurts performance. Improve upon this by using block_iter_reset() at the start of each iteration instead. This has the added benifit of testing block_iter_reset(), which currently remains untested. Similarly, remove reftable_record_release() for a reftable record that is still in use. Mentored-by: Patrick Steinhardt <ps@pks.im> Mentored-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Chandra Pratap committed Aug 21, 2024 at 18:00 UTC 31216ee28a452d39d9fba6cd72d8b072eab50af1

1 file changed +2 -6

t/unit-tests/t-reftable-block.c

+2 -6

@@ -78,11 +78,8 @@ static void t_block_read_write(void)

78 j++;

79 }

81 - reftable_record_release(&rec);

82 - block_iter_close(&it);

83 -

81 for (i = 0; i < N; i++) {

85 - struct block_iter it = BLOCK_ITER_INIT;

82 + block_iter_reset(&it);

83 reftable_record_key(&recs[i], &want);

85 ret = block_iter_seek_key(&it, &br, &want);

@@ -100,11 +97,10 @@ static void t_block_read_write(void)

97 ret = block_iter_next(&it, &rec);

98 check_int(ret, ==, 0);

99 check(reftable_record_equal(&recs[10 * (i / 10)], &rec, GIT_SHA1_RAWSZ));

103 -

104 - block_iter_close(&it);

100 }

101

102 block_reader_release(&br);

103 + block_iter_close(&it);

104 reftable_record_release(&rec);

105 reftable_block_done(&br.block);

106 strbuf_release(&want);