t9105-git-svn-commit-diff.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Jan 12, 2016 at 10:45 UTC
32858a01506b22963cfd5f8c8db95486f26133af
1 file changed
+2
-2
t/t9105-git-svn-commit-diff.sh
+2
-2
@@ -18,8 +18,8 @@ test_expect_success 'initialize repo' '
18
git commit -a -m "another"
19
'
20
21
-head=`git rev-parse --verify HEAD^0`
22
-prev=`git rev-parse --verify HEAD^1`
21
+head=$(git rev-parse --verify HEAD^0)
22
+prev=$(git rev-parse --verify HEAD^1)
23
24
# the internals of the commit-diff command are the same as the regular
25
# commit, so only a basic test of functionality is needed since we've