lib-submodule-update.sh: reduce use of subshell by using "git -C"
We write (cd <dir> && git <cmd>) to avoid cd <dir> && git <cmd> && cd .. that allows a breakage in one part of the test script to leave the entire test process in an unexpected place. Modern version of Git allows us to do this more concisely with "git -C <dir> <cmd>". Signed-off-by: Stefan Beller <sbeller@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Stefan Beller committed
Jan 11, 2017 at 10:47 UTC
3290fe6dd2a7e2bb35ac760443335dec58802ff1
1 file changed
+1
-4
t/lib-submodule-update.sh
+1
-4
@@ -69,10 +69,7 @@ create_lib_submodule_repo () {
69
70
git checkout -b "replace_sub1_with_directory" "add_sub1" &&
71
git submodule update &&
72
- (
73
- cd sub1 &&
74
- git checkout modifications
75
- ) &&
72
+ git -C sub1 checkout modifications &&
73
git rm --cached sub1 &&
74
rm sub1/.git* &&
75
git config -f .gitmodules --remove-section "submodule.sub1" &&