CodingGuidelines: drop arithmetic expansion advice to use "$x"
The advice to use "$x" rather than "x" in arithmetric expansion was working around a dash bug fixed in 0.5.4. Even Debian oldstable has 0.5.8 these days. And in the meantime, we've added almost two dozen instances of the "x" form which you can find with: git grep '$(([a-z]' and nobody seems to have complained. Let's declare this workaround obsolete and simplify our style guide. Helped-by: Danh Doan <congdanhqx@gmail.com> Signed-off-by: Jeff King <peff@peff.net> Reviewed-by: Carlo Marcelo Arenas Belón <carenas@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
May 4, 2020 at 12:07 UTC
32b5fe7f0e2cb798954b3e01b990bc140706e191
1 file changed
-4
Documentation/CodingGuidelines
-4
@@ -97,10 +97,6 @@ For shell scripts specifically (not exhaustive):
97
98
- We use Arithmetic Expansion $(( ... )).
99
100
- - Inside Arithmetic Expansion, spell shell variables with $ in front
101
- of them, as some shells do not grok $((x)) while accepting $(($x))
102
- just fine (e.g. dash older than 0.5.4).
103
-
100
- We do not use Process Substitution <(list) or >(list).
101
102
- Do not write control structures on a single line with semicolon.