entry.c: convert strcpy to xsnprintf
This particular conversion is non-obvious, because nobody has passed our function the length of the destination buffer. However, the interface to checkout_entry specifies that the buffer must be at least TEMPORARY_FILENAME_LENGTH bytes long, so we can check that (meaning the existing code was not buggy, but merely worrisome to somebody reading it). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Sep 24, 2015 at 17:06 UTC
330c8e26701c33f1d74dbe3c2692f29b5ed4ba5f
1 file changed
+2
-2
entry.c
+2
-2
@@ -96,8 +96,8 @@ static int open_output_fd(char *path, const struct cache_entry *ce, int to_tempf
96
{
97
int symlink = (ce->ce_mode & S_IFMT) != S_IFREG;
98
if (to_tempfile) {
99
- strcpy(path, symlink
100
- ? ".merge_link_XXXXXX" : ".merge_file_XXXXXX");
99
+ xsnprintf(path, TEMPORARY_FILENAME_LENGTH, "%s",
100
+ symlink ? ".merge_link_XXXXXX" : ".merge_file_XXXXXX");
101
return mkstemp(path);
102
} else {
103
return create_file(path, !symlink ? ce->ce_mode : 0666);