@matheusbsbs / matheus-bagliano / commits / 332b56b762

builtin/bundle: abort "verify" early when there is no repository

Verifying a bundle requires us to have a repository. This is encoded in `verify_bundle()`, which will return an error if there is no repository. We call `open_bundle()` before we call `verify_bundle()` though, which already performs some verifications even though we may ultimately abort due to a missing repository. This is problematic because `open_bundle()` already reads the bundle header and verifies that it contains a properly formatted hash. When there is no repository we have no clue what hash function to expect though, so we always end up assuming SHA1 here, which may or may not be correct. Furthermore, we are about to stop initializing `the_hash_algo` when there is no repository, which will lead to segfaults. Check early on whether we have a repository to fix this issue. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Patrick Steinhardt committed May 7, 2024 at 06:53 UTC 332b56b7623c641dbf2f7712e338c0ca2dd423be

1 file changed +5

builtin/bundle.c

@@ -140,6 +140,11 @@ static int cmd_bundle_verify(int argc, const char **argv, const char *prefix) {

140 builtin_bundle_verify_usage, options, &bundle_file);

141 /* bundle internals use argv[1] as further parameters */

142

143 + if (!startup_info->have_repository) {

144 + ret = error(_("need a repository to verify a bundle"));

145 + goto cleanup;

146 + }

147 +

148 if ((bundle_fd = open_bundle(bundle_file, &header, &name)) < 0) {

149 ret = 1;

150 goto cleanup;