format-patch: refactor generate_commit_list_cover
Refactor for readability and remove unnecessary initialization. Signed-off-by: Mirko Faina <mroik@delayed.space> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Mirko Faina committed
Mar 23, 2026 at 17:57 UTC
3482b4278793f3adb1fa811dd30c637563ca9cec
1 file changed
+3
-4
builtin/log.c
+3
-4
@@ -1376,12 +1376,11 @@ static void generate_commit_list_cover(FILE *cover_file, const char *format,
1376
struct pretty_print_context ctx = {0};
1377
struct rev_info rev = REV_INFO_INIT;
1378
1379
- strbuf_init(&commit_line, 0);
1379
rev.total = n;
1380
ctx.rev = &rev;
1382
- for (int i = n - 1; i >= 0; i--) {
1383
- rev.nr = n - i;
1384
- repo_format_commit_message(the_repository, list[i], format,
1381
+ for (int i = 1; i <= n; i++) {
1382
+ rev.nr = i;
1383
+ repo_format_commit_message(the_repository, list[n - i], format,
1384
&commit_line, &ctx);
1385
fprintf(cover_file, "%s\n", commit_line.buf);
1386
strbuf_reset(&commit_line);