t2016: add a NEEDSWORK about the PERL prerequisite

Since the builtin add-p is used when $GIT_TEST_ADD_I_USE_BUILTIN is given, we should replace the PERL prerequisite with an ADD_I prerequisite which first checks if $GIT_TEST_ADD_I_USE_BUILTIN is defined before checking PERL.[0] Mark this in a NEEDSWORK so that it can be addressed at a later time. [0]: https://lore.kernel.org/git/xmqqsgat7ttf.fsf@gitster.c.googlers.com/ Signed-off-by: Denton Liu <liu.denton@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Denton Liu committed Oct 7, 2020 at 00:56 UTC 35166b1fb54d6c3ca0d9150fd766598a2d3d17b2

1 file changed +4

t/t2016-checkout-patch.sh

@@ -18,6 +18,10 @@ test_expect_success PERL 'setup' '

19 # note: bar sorts before dir/foo, so the first 'n' is always to skip 'bar'

21 +# NEEDSWORK: Since the builtin add-p is used when $GIT_TEST_ADD_I_USE_BUILTIN

22 +# is given, we should replace the PERL prerequisite with an ADD_I prerequisite

23 +# which first checks if $GIT_TEST_ADD_I_USE_BUILTIN is defined before checking

24 +# PERL.

25 test_expect_success PERL 'saying "n" does nothing' '

26 set_and_save_state dir/foo work head &&

27 test_write_lines n n | git checkout -p &&