git-p4: Change p4 command invocation
Change p4 command invocation to avoid going through the shell. This allows names with spaces and wildcards to work. Signed-off-by: Pete Wyckoff <pw@padd.com> Signed-off-by: Vitor Antunes <vitor.hda@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Pete Wyckoff committed
Jan 25, 2012 at 23:48 UTC
3558f32f1f5fdb3d566e39f6e07cd3f97d124da6
1 file changed
+1
-1
contrib/fast-import/git-p4
+1
-1
@@ -1984,7 +1984,7 @@ class P4Sync(Command, P4UserMap):
1984
def importChanges(self, changes):
1985
cnt = 1
1986
for change in changes:
1987
- description = p4Cmd("describe %s" % change)
1987
+ description = p4Cmd(["describe", str(change)])
1988
self.updateOptionDict(description)
1989
1990
if not self.silent: