@matheusbsbs / matheus-bagliano / commits / 35a71f1402

credential-cache: ignore "connection refused" errors

The credential-cache helper will try to connect to its daemon over a unix socket. Originally, a failure to do so was silently ignored, and we would either give up (if performing a "get" or "erase" operation), or spawn a new daemon (for a "store" operation). But since 8ec6c8d, we try to report more errors. We detect a missing daemon by checking for ENOENT on our connection attempt. If the daemon is missing, we continue as before (giving up or spawning a new daemon). For any other error, we die and report the problem. However, checking for ENOENT is not sufficient for a missing daemon. We might also get ECONNREFUSED if a dead daemon process left a stale socket. This generally shouldn't happen, as the daemon cleans up after itself, but the daemon may not always be given a chance to do so (e.g., power loss, "kill -9"). The resulting state is annoying not just because the helper outputs an extra useless message, but because it actually blocks the helper from spawning a new daemon to replace the stale socket. Fix it by checking for ECONNREFUSED. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Jan 17, 2012 at 01:02 UTC 35a71f1402b40b580d985a9d7e5fb1c9ec4d0232

1 file changed +1 -1

credential-cache.c

+1 -1

@@ -72,7 +72,7 @@ static void do_cache(const char *socket, const char *action, int timeout,

72 }

74 if (send_request(socket, &buf) < 0) {

75 - if (errno != ENOENT)

75 + if (errno != ENOENT && errno != ECONNREFUSED)

76 die_errno("unable to connect to cache daemon");

77 if (flags & FLAG_SPAWN) {

78 spawn_daemon(socket);