@matheusbsbs / matheus-bagliano / commits / 37537d6472

attr: adjust a mismatched data type

On platforms where `size_t` does not have the same width as `unsigned long`, passing a pointer to the former when a pointer to the latter is expected can lead to problems. Windows and 32-bit Linux are among the affected platforms. In this instance, we want to store the size of the blob that was read in that variable. However, `read_blob_data_from_index()` passes that pointer to `read_object_file()` which expects an `unsigned long *`. Which means that on affected platforms, the variable is not fully populated and part of its value is left uninitialized. (On Big-Endian platforms, this problem would be even worse.) The consequence is that depending on the uninitialized memory's contents, we may erroneously reject perfectly fine attributes. Let's address this by passing a pointer to a variable of the expected data type. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Johannes Schindelin committed Jan 12, 2023 at 01:05 UTC 37537d6472d87098d455b6a0c36885997ea81a85

1 file changed +1 -1

attr.c

+1 -1

@@ -752,7 +752,7 @@ static struct attr_stack *read_attr_from_index(struct index_state *istate,

752 struct attr_stack *res;

753 char *buf, *sp;

754 int lineno = 0;

755 - size_t size;

755 + unsigned long size;

756

757 if (!istate)

758 return NULL;