clone: make sure we support the transport type
If we use an unsupported transport (e.g., http when curl support is not compiled in), transport_get reports an error to the user, but we still get a transport object. We need to manually check and abort the clone process at that point, or we end up with a segfault. Noticed by Thomas Rast. Signed-off-by: Jeff King <peff@peff.net> Acked-by: Daniel Barkalow <barkalow@iabervon.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
May 27, 2008 at 10:28 UTC
37b78c25476d752953dc541e46fbb6bd5017edf7
1 file changed
+3
builtin-clone.c
+3
@@ -449,6 +449,9 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
449
struct remote *remote = remote_get(argv[0]);
450
struct transport *transport = transport_get(remote, argv[0]);
451
452
+ if (!transport->get_refs_list || !transport->fetch)
453
+ die("Don't know how to clone %s", transport->url);
454
+
455
transport_set_option(transport, TRANS_OPT_KEEP, "yes");
456
457
if (option_depth)