parseopt: restore const qualifier to parsed filename
This was unintentionally dropped in ccfcaf399f (parseopt: values of pathname type can be prefixed with :(optional), 2025-09-28). Notably, continue dropping the const qualifier when free'ing value; see 4049b9cfc0 (fix const issues with some functions, 2007-10-16) or 83838d5c1b (cast variable in call to free() in builtin/diff.c and submodule.c, 2011-11-06) for more details on why. Suggested-by: Phillip Wood <phillip.wood@dunelm.org.uk> Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
D. Ben Knoble committed
Nov 2, 2025 at 11:17 UTC
383e5e1c4bfa604bcd479100258b4ff354dbaabb
1 file changed
+1
-1
parse-options.c
+1
-1
@@ -213,7 +213,7 @@ static enum parse_opt_result do_get_value(struct parse_opt_ctx_t *p,
213
if (unset)
214
value = NULL;
215
else if (opt->flags & PARSE_OPT_OPTARG && !p->opt)
216
- value = (char *)opt->defval;
216
+ value = (const char *)opt->defval;
217
else {
218
int err = get_arg(p, opt, flags, &value);
219
if (err)