t4010-diff-pathspec.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Apr 30, 2014 at 09:22 UTC
38b2e5d12cbe681bff8f31cf10e3de8bd6f6db52
1 file changed
+2
-2
t/t4010-diff-pathspec.sh
+2
-2
@@ -18,7 +18,7 @@ test_expect_success \
18
mkdir path1 &&
19
echo rezrov >path1/file1 &&
20
git update-index --add file0 path1/file1 &&
21
- tree=`git write-tree` &&
21
+ tree=$(git write-tree) &&
22
echo "$tree" &&
23
echo nitfol >file0 &&
24
echo yomin >path1/file1 &&
@@ -131,7 +131,7 @@ test_expect_success 'diff multiple wildcard pathspecs' '
131
mkdir path2 &&
132
echo rezrov >path2/file1 &&
133
git update-index --add path2/file1 &&
134
- tree3=`git write-tree` &&
134
+ tree3=$(git write-tree) &&
135
git diff --name-only $tree $tree3 -- "path2*1" "path1*1" >actual &&
136
cat <<-\EOF >expect &&
137
path1/file1