http: re-word http error message
When we report an http error code, we say something like: error: The requested URL reported failure: 403 Forbidden while accessing http://example.com/repo.git Everything between "error:" and "while" is written by curl, and the resulting sentence is hard to read (especially because there is no punctuation between curl's sentence and the remainder of ours). Instead, let's re-order this to give better flow: error: unable to access 'http://example.com/repo.git: The requested URL reported failure: 403 Forbidden This is still annoyingly long, but at least reads more clearly left to right. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Apr 5, 2013 at 18:22 UTC
39a570f26c953e8277a6a26c00da657b240dcdd4
1 file changed
+1
-1
http.c
+1
-1
@@ -943,7 +943,7 @@ cleanup:
943
944
void http_error(const char *url)
945
{
946
- error("%s while accessing %s", curl_errorstr, url);
946
+ error("unable to access '%s': %s", url, curl_errorstr);
947
}
948
949
int http_fetch_ref(const char *base, struct ref *ref)