packed-backend: don't adjust the reference count on lock/unlock

The old code incremented the packed ref cache reference count when acquiring the packed-refs lock, and decremented the count when releasing the lock. This is unnecessary because: * Another process cannot change the packed-refs file because it is locked. * When we ourselves change the packed-refs file, we do so by first modifying the packed ref-cache, and then writing the data from the ref-cache to disk. So the packed ref-cache remains fresh because any changes that we plan to make to the file are made in the cache first anyway. So there is no reason for the cache to become stale. Moreover, the extra reference count causes a problem if we intentionally clear the packed refs cache, as we sometimes need to do if we change the cache in anticipation of writing a change to disk, but then the write to disk fails. In that case, `packed_refs_unlock()` would have no easy way to find the cache whose reference count it needs to decrement. This whole issue will soon become moot due to upcoming changes that avoid changing the in-memory cache as part of updating the packed-refs on disk, but this change makes that transition easier. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Michael Haggerty committed Sep 8, 2017 at 15:51 UTC 39c8df0cfe124565783bfc5eaaa3285c06b83fbf
1 file changed +5 -5
refs/packed-backend.c
+5 -5
@@ -525,7 +525,6 @@ int packed_refs_lock(struct ref_store *ref_store, int flags, struct strbuf *err)
525 "packed_refs_lock");
526 static int timeout_configured = 0;
527 static int timeout_value = 1000;
528 - struct packed_ref_cache *packed_ref_cache;
528
529 if (!timeout_configured) {
530 git_config_get_int("core.packedrefstimeout", &timeout_value);
@@ -560,9 +559,11 @@ int packed_refs_lock(struct ref_store *ref_store, int flags, struct strbuf *err)
559 */
560 validate_packed_ref_cache(refs);
561
563 - packed_ref_cache = get_packed_ref_cache(refs);
564 - /* Increment the reference count to prevent it from being freed: */
565 - acquire_packed_ref_cache(packed_ref_cache);
562 + /*
563 + * Now make sure that the packed-refs file as it exists in the
564 + * locked state is loaded into the cache:
565 + */
566 + get_packed_ref_cache(refs);
567 return 0;
568 }
569
@@ -576,7 +577,6 @@ void packed_refs_unlock(struct ref_store *ref_store)
577 if (!is_lock_file_locked(&refs->lock))
578 die("BUG: packed_refs_unlock() called when not locked");
579 rollback_lock_file(&refs->lock);
579 - release_packed_ref_cache(refs->cache);
580 }
581
582 int packed_refs_is_locked(struct ref_store *ref_store)