t/t6002-rev-list-bisect.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Jan 7, 2016 at 14:51 UTC
3a9992b06240574d93613beb7ec028a1d8e914c6
1 file changed
+3
-3
t/t6002-rev-list-bisect.sh
+3
-3
@@ -27,9 +27,9 @@ test_bisection_diff()
27
# Test if bisection size is close to half of list size within
28
# tolerance.
29
#
30
- _bisect_err=`expr $_list_size - $_bisection_size \* 2`
31
- test "$_bisect_err" -lt 0 && _bisect_err=`expr 0 - $_bisect_err`
32
- _bisect_err=`expr $_bisect_err / 2` ; # floor
30
+ _bisect_err=$(expr $_list_size - $_bisection_size \* 2)
31
+ test "$_bisect_err" -lt 0 && _bisect_err=$(expr 0 - $_bisect_err)
32
+ _bisect_err=$(expr $_bisect_err / 2) ; # floor
33
34
test_expect_success \
35
"bisection diff $_bisect_option $_head $* <= $_max_diff" \