Fix is_gitfile() for files too small or larger than PATH_MAX to be a gitfile

The logic to check whether a file is a gitfile used the heuristics that a gitfile cannot be larger than PATH_MAX or smaller than 10 bytes (as its contents is "gitdir: " followed by a path) and returned early. But it returned with a wrong value. It should have said "this cannot possibly be a gitfile" by returning 0, but it returned 1 instead. Our test cases do not cover this, as the bundle files produced are smaller than PATH_MAX, except on Windows. While at it, fix the faulty logic that the path stored in a gitfile cannot be larger than PATH_MAX-sizeof("gitdir: "). Problem identified by running the test suite in msysGit, offending commit identified by Jörg Rosenkranz. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Johannes Schindelin committed Oct 11, 2011 at 14:25 UTC 3ac64370164fb80e92c3c9136210d3a49f1e01fa
1 file changed +2 -2
transport.c
+2 -2
@@ -875,8 +875,8 @@ static int is_gitfile(const char *url)
875 return 0;
876 if (!S_ISREG(st.st_mode))
877 return 0;
878 - if (st.st_size < 10 || st.st_size > PATH_MAX)
879 - return 1;
878 + if (st.st_size < 10 || st.st_size > 9 + PATH_MAX)
879 + return 0;
880
881 fd = open(url, O_RDONLY);
882 if (fd < 0)