MinGW: Quote arguments for subprocesses that contain a single-quote

Before a process can be spawned by mingw_spawnve, arguments must be surrounded by double-quotes if special characters are present. This is necessary because the startup code of the spawned process will expand arguments that look like glob patterns. "Normal" Windows command line utilities expand only * and ?, but MSYS programs, including bash, are different: They also expand braces, and this has already been taken care of by compat/mingw.c:quote_arg(). But MSYS programs also treat single-quotes in a special way: Arguments between single-quotes are spliced together (with spaces) into a word. With this patch this treatment is avoided by quoting arguments that contain single-quotes. This lets t4252 pass on Windows. Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Johannes Sixt committed Mar 24, 2009 at 21:43 UTC 3aea1a5a899f5ff34f12d0cd6d8e903ddcfeef3a

1 file changed +1 -1

compat/mingw.c

+1 -1

@@ -457,7 +457,7 @@ static const char *quote_arg(const char *arg)

457 const char *p = arg;

458 if (!*p) force_quotes = 1;

459 while (*p) {

460 - if (isspace(*p) || *p == '*' || *p == '?' || *p == '{')

460 + if (isspace(*p) || *p == '*' || *p == '?' || *p == '{' || *p == '\'')

461 force_quotes = 1;

462 else if (*p == '"')

463 n++;