@matheusbsbs / matheus-bagliano / commits / 3b9a2b07ef

test-hashmap: squelch gcc compiler warning

At least on this developer's MacOSX (Snow Leopard, gcc-4.2.1), GCC prints a warning that 'hash' may be used uninitialized when compiling test-hashmap that 'hash' may be used uninitialized (but GCC 4.6.3 on this developer's Ubuntu server does not report this problem). The old compiler is wrong, of course, as the switch (method & 3) statement already handles all the possible cases, but that does not help in a scenario where it is hard or impossible to upgrade to a newer compiler (e.g. being stuck on an older MacOSX and having to rely on Xcode). So let's just initialize the variable and be done with it, it is hardly a crucial part of the code because it is only used by the test suite and invisible to the end users. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Johannes Schindelin committed Dec 9, 2014 at 10:48 UTC 3b9a2b07ef411d9f0066db2a5d98ff5a1f6669a5

1 file changed +1 -1

test-hashmap.c

+1 -1

@@ -48,7 +48,7 @@ static struct test_entry *alloc_test_entry(int hash, char *key, int klen,

49 static unsigned int hash(unsigned int method, unsigned int i, const char *key)

50 {

51 - unsigned int hash;

51 + unsigned int hash = 0;

52 switch (method & 3)

53 {

54 case HASH_METHOD_FNV: