mingw: forbid translating ERROR_SUCCESS to an errno value
Johannes Sixt pointed out that the `err_win_to_posix()` function mishandles `ERROR_SUCCESS`: it maps it to `ENOSYS`. The only purpose of this function is to map Win32 API errors to `errno` ones, and there is actually no equivalent to `ERROR_SUCCESS`: the idea of `errno` is that it will only be set in case of an error, and left alone in case of success. Therefore, as pointed out by Junio Hamano, it is a bug to call this function when there was not even any error to map. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Johannes Schindelin committed
Dec 2, 2019 at 11:33 UTC
3ba3720b3f187644ac0186a4637898f8e8f85a91
1 file changed
+1
compat/mingw.c
+1
@@ -114,6 +114,7 @@ int err_win_to_posix(DWORD winerr)
114
case ERROR_SHARING_BUFFER_EXCEEDED: error = ENFILE; break;
115
case ERROR_SHARING_VIOLATION: error = EACCES; break;
116
case ERROR_STACK_OVERFLOW: error = ENOMEM; break;
117
+ case ERROR_SUCCESS: BUG("err_win_to_posix() called without an error!");
118
case ERROR_SWAPERROR: error = ENOENT; break;
119
case ERROR_TOO_MANY_MODULES: error = EMFILE; break;
120
case ERROR_TOO_MANY_OPEN_FILES: error = EMFILE; break;