@matheusbsbs / matheus-bagliano / commits / 3be7e06713
Fork 0

t9120: don't expect failure with SVN_HTTPD_PORT unset

The test still passes when SVN_HTTPD_PORT is not set. Futhermore, t9115 and t9118 don't check if SVN_HTTPD_PORT is set even though they both use start_httpd() from lib-git-svn.sh. Admittedly, the test is not very meaningful without SVN_HTTPD_PORT, as commit f5530b (support for funky branch and project names over HTTP(S) 2007-11-11) states that the URI escaping is only done over HTTP(S). Signed-off-by: Stephen Boyd <bebarino@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Stephen Boyd committed May 25, 2009 at 23:15 UTC 3be7e06713462110f0ff15f54f864b5ecf646814
1 file changed +6 -11
t/t9120-git-svn-clone-with-percent-escapes.sh
+6 -11
@@ -14,17 +14,12 @@ test_expect_success 'setup svnrepo' '
14 start_httpd
15 '
16
17 -if test "$SVN_HTTPD_PORT" = ""
18 -then
19 - test_expect_failure 'test clone with percent escapes - needs SVN_HTTPD_PORT set' 'false'
20 -else
21 - test_expect_success 'test clone with percent escapes' '
22 - git svn clone "$svnrepo/pr%20ject" clone &&
23 - cd clone &&
24 - git rev-parse refs/${remotes_git_svn} &&
25 - cd ..
26 - '
27 -fi
17 +test_expect_success 'test clone with percent escapes' '
18 + git svn clone "$svnrepo/pr%20ject" clone &&
19 + cd clone &&
20 + git rev-parse refs/${remotes_git_svn} &&
21 + cd ..
22 +'
23
24 stop_httpd
25