clone: drop dest parameter from copy_alternates()
Ever since the inception of this function in e6baf4a1ae (clone: clone from a repository with relative alternates, 2011-08-22), the "dest" parameter has been unused. Instead, we use add_to_alternates_file(), which relies on git_pathdup() to find the right file. That in turn works because we will have initialized and entered the destination repo by this point. It's a bit subtle, but this is how it has always worked. And if our assumptions change, the test in t5601 from e6baf4a1ae should let us know. In the meantime, let's drop this unused and confusing parameter from copy_alternates(). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
May 9, 2019 at 17:29 UTC
3c1dce8835a983ffc34f6656f665a04d9ce7da79
1 file changed
+2
-3
builtin/clone.c
+2
-3
@@ -357,8 +357,7 @@ static void setup_reference(void)
357
add_one_reference, &required);
358
}
359
360
-static void copy_alternates(struct strbuf *src, struct strbuf *dst,
361
- const char *src_repo)
360
+static void copy_alternates(struct strbuf *src, const char *src_repo)
361
{
362
/*
363
* Read from the source objects/info/alternates file
@@ -439,7 +438,7 @@ static void copy_or_link_directory(struct strbuf *src, struct strbuf *dest,
438
439
/* Files that cannot be copied bit-for-bit... */
440
if (!strcmp(src->buf + src_baselen, "/info/alternates")) {
442
- copy_alternates(src, dest, src_repo);
441
+ copy_alternates(src, src_repo);
442
continue;
443
}
444