@matheusbsbs / matheus-bagliano / commits / 3c479c37f8
Fork 0

Git.pm: Introduce fast get_object() method

Direct .xs routine. Note that it does not work 100% correctly when you juggle multiple repository objects, but it is not that bad either. The trouble is that we might reuse packs information for another Git project; that is not an issue since Git depends on uniqueness of SHA1 ids so if we have found the object somewhere else, it is nevertheless going to be the same object. It merely makes object existence detection through this method unreliable; it is duly noted in the documentation. At least that's how I see it, I hope I didn't overlook any other potential problem. I tested it for memory leaks and it appears to be doing ok. Signed-off-by: Petr Baudis <pasky@suse.cz> Signed-off-by: Junio C Hamano <junkio@cox.net>

Petr Baudis committed Jul 3, 2006 at 22:48 UTC 3c479c37f8651d09e1d08b8d6ea9757164ee1235
2 files changed +42
perl/Git.pm
+18
@@ -572,6 +572,24 @@ sub ident_person {
572 }
573
574
575 +=item get_object ( TYPE, SHA1 )
576 +
577 +Return contents of the given object in a scalar string. If the object has
578 +not been found, undef is returned; however, do not rely on this! Currently,
579 +if you use multiple repositories at once, get_object() on one repository
580 +_might_ return the object even though it exists only in another repository.
581 +(But do not rely on this behaviour either.)
582 +
583 +The method must be called on a repository instance.
584 +
585 +Implementation of this method is very fast; no external command calls
586 +are involved. That's why it is broken, too. ;-)
587 +
588 +=cut
589 +
590 +# Implemented in Git.xs.
591 +
592 +
593 =item hash_object ( TYPE, FILENAME )
594
595 =item hash_object ( TYPE, FILEHANDLE )
perl/Git.xs
+24
@@ -111,6 +111,30 @@ CODE:
111 free((char **) argv);
112 }
113
114 +
115 +SV *
116 +xs_get_object(type, id)
117 + char *type;
118 + char *id;
119 +CODE:
120 +{
121 + unsigned char sha1[20];
122 + unsigned long size;
123 + void *buf;
124 +
125 + if (strlen(id) != 40 || get_sha1_hex(id, sha1) < 0)
126 + XSRETURN_UNDEF;
127 +
128 + buf = read_sha1_file(sha1, type, &size);
129 + if (!buf)
130 + XSRETURN_UNDEF;
131 + RETVAL = newSVpvn(buf, size);
132 + free(buf);
133 +}
134 +OUTPUT:
135 + RETVAL
136 +
137 +
138 char *
139 xs_hash_object_pipe(type, fd)
140 char *type;