config: make git_configset_get_string_tmp() private
This method was created in f1de981e8 (config: fix leaks from git_config_get_string_const(), 2020-08-14) but its only use was in the repo_config_get_string_tmp() method, also declared in config.h and implemented in config.c. Since this is otherwise unused and is a very similar implementation to git_configset_get_value(), let's remove this declaration. Signed-off-by: Derrick Stolee <dstolee@microsoft.com> Reviewed-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Derrick Stolee committed
Feb 7, 2022 at 21:33 UTC
3ce113827287079dced9aaf9c5d1e1734ecaa265
2 files changed
+2
-3
config.c
+2
-2
@@ -2179,8 +2179,8 @@ int git_configset_get_string(struct config_set *cs, const char *key, char **dest
2179
return 1;
2180
}
2181
2182
-int git_configset_get_string_tmp(struct config_set *cs, const char *key,
2183
- const char **dest)
2182
+static int git_configset_get_string_tmp(struct config_set *cs, const char *key,
2183
+ const char **dest)
2184
{
2185
const char *value;
2186
if (!git_configset_get_value(cs, key, &value)) {
config.h
-1
@@ -494,7 +494,6 @@ void git_configset_clear(struct config_set *cs);
494
int git_configset_get_value(struct config_set *cs, const char *key, const char **dest);
495
496
int git_configset_get_string(struct config_set *cs, const char *key, char **dest);
497
-int git_configset_get_string_tmp(struct config_set *cs, const char *key, const char **dest);
497
int git_configset_get_int(struct config_set *cs, const char *key, int *dest);
498
int git_configset_get_ulong(struct config_set *cs, const char *key, unsigned long *dest);
499
int git_configset_get_bool(struct config_set *cs, const char *key, int *dest);